Fix line-tables-only on macOS 15 #739
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...ok |
workingjubilee
changed the title
workingjubilee
force-pushed
the
investigate-macos-15-further
branch
from
127c65b to
a3c48a6
Compare
|
@madsmtm I am losing my mind that this was effectively the only problem. |
madsmtm
approved these changes
Sep 26, 2025
| cc::Build::new() | ||
| .opt_level(0) | ||
| .debug(false) | ||
| .flag("-g1") |
There was a problem hiding this comment.
Nit: Really should be:
Suggested change
| .flag("-g1") | |
| .flag("-gline-tables-only") |
For clarity.
(If that is supported by all tested compiler versions)
There was a problem hiding this comment.
Tried that.
Breaks on half the platforms because that's a clang-only option and gcc doesn't support it, and cc will opportunistically find and use gcc instead.
workingjubilee
force-pushed
the
investigate-macos-15-further
branch
from
a3c48a6 to
1cea408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730 for good.
There was a subtle change in how appleclang interprets command lines between Xcode 16.2 and Xcode 16.4, which caused the cc-rs settings of first setting
debug(false)and then passing an explicit debuginfo setting to fail. This might have been inherited from upstream clang, and that is unclear to me. In any case it seems we can just pass-g1and that works fine.