Refactoring #225
Merged
Refactoring #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the parsing can fail.
It was unnecessarily complicated. This should make it simpler to understand and modify.
We don't currently handle duplicates consistently everywhere, and I don't think that it is needed. Let's remove these tests and the corresponding functionality to keep the parsers simpler.
The rollup mode is nullable in the DB, so let's respect that, and only fill in the default value later when actually reading the rollup mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR performs a bunch of refactorings after the recent whirlwind of PRs. Most importantly, it refactors the parsers to make their logic simpler and leverage pattern matching more.