Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to skip verifying bisection ranges #262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

clubby789
Copy link
Contributor

Closes #258

Adds two options for bypassing verifying the start and end of nightly and CI ranges. If no start nightly has been provided, the start date will be detected as usual.

@oli-obk
Copy link
Contributor

oli-obk commented Feb 28, 2023

What's this feature doing? speeding up bisection by ignoring the start/end so you only run things in between the start/end?

@clubby789
Copy link
Contributor Author

Yeah, if you know for sure that a regression happened between (for example) stable and beta, you can save some time by skipping checking those

@oli-obk
Copy link
Contributor

oli-obk commented Feb 28, 2023

Hmm... that needs a bit more documentation on the flags. To me it sounded like verifying that the commit/nightly exists or somehow is valid in itself. But this is solely about not running the bisection on the start/end and only running it between the given values

Also: why do we have different flags for CI artifacts and nightly?

@clubby789
Copy link
Contributor Author

I'll update the help to document this better. I made two flags so that we don't skip verifying the CI range if the user has only provided nightly dates. It would probably make more sense to have it be a single flag that skips verifying whichever of the two the user has provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Add option to skip verifying the start/end of a range
2 participants