Skip to content

Avoid using floor in rem_pio2 #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

quaternic
Copy link
Contributor

Possible workaround for #976 (comment)

I'm not familiar with the details of this (rather complex) algorithm and implementation, but the comments claim that x must be positive, and that would seem to imply that the z in floor(z) also is.

@folkertdev
Copy link
Contributor

This passes the test suite (just needs a formatting fix), and with this change the floor/ceil assembly versions also pass the test suite as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants