Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates CMake to 3.30.2 #150

Closed
wants to merge 2 commits into from
Closed

Updates CMake to 3.30.2 #150

wants to merge 2 commits into from

Conversation

Mottl
Copy link

@Mottl Mottl commented Aug 16, 2024

This commit updates CMake to 3.30.2 and fixes rust-lang/docs.rs#2587

@Mottl Mottl changed the title Updates CMake to 3.30.2 [wip] Updates CMake to 3.30.2 Aug 16, 2024
@Mottl Mottl changed the title [wip] Updates CMake to 3.30.2 Updates CMake to 3.30.2 Aug 16, 2024
@Mottl
Copy link
Author

Mottl commented Aug 16, 2024

@syphar, now I think it's good to review

@syphar
Copy link
Member

syphar commented Aug 18, 2024

cross-post from rust-lang/docs.rs#2587 (comment)

I'm sorry if I wasn't clear enough in my messages above.
Right now we only accept standard ubuntu packages into the builder image due to the maintenance / security burden.
So upgrading to the latest LTS is the way to solve this issue.

An alternative is to work on rust-lang/docs.rs#315 (allow custom docker images), but my hunch is that upgrading the main build env is less work.

@Mottl
Copy link
Author

Mottl commented Aug 21, 2024

Closed due to #151

@Mottl Mottl closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please upgrade CMake to 3.28
2 participants