Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise crate deletion download limit #10266

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Raise crate deletion download limit #10266

merged 1 commit into from
Dec 30, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 23, 2024

As discussed in the last crates.io team meeting the current limit of just 100 downloads per month was too conservative. This commit raises the limit to 500 downloads per month to make self-service deletions a bit more viable in practice.

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Dec 23, 2024
@Turbo87 Turbo87 requested a review from a team December 23, 2024 13:41
Rustin170506
Rustin170506 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@Rustin170506
Copy link
Member

The snapshot needs to be updated.

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 23, 2024

The snapshot needs to be updated.

oops, thought I had caught all of them but apparently I missed the new OpenAPI snapshot 😅

@Turbo87 Turbo87 force-pushed the deletion-download-limit branch from 49c3363 to 0974aa9 Compare December 23, 2024 14:43
@Turbo87
Raise crate deletion download limit
8b72d8a 
As discussed in the last crates.io team meeting the current limit of just 100 downloads per month was too conservative. This commit raises the limit to 500 downloads per month to make self-service deletions a bit more viable in practice.
@Turbo87 Turbo87 force-pushed the deletion-download-limit branch from 0974aa9 to 8b72d8a Compare December 25, 2024 18:54
LawnGnome
LawnGnome approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, but as discussed last week, let's make sure we put a rough rubric on how we got to 500 in the ops guide.

eth3lbert
eth3lbert reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@eth3lbert eth3lbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention that we also have an experimenter #10273 who is interested in this 😉

@Turbo87 Turbo87 merged commit c50c66b into rust-lang:main Dec 30, 2024
9 checks passed
@Turbo87 Turbo87 deleted the deletion-download-limit branch December 30, 2024 08:18
@Turbo87 Turbo87 mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth3lbert eth3lbert eth3lbert left review comments

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@LawnGnome LawnGnome LawnGnome approved these changes

Assignees
No one assigned
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Turbo87 @Rustin170506 @LawnGnome @eth3lbert