Include default_version by default
#10344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
force-pushed
the
app-default-version
branch
from
a03882a to
ddfede2
Compare
eth3lbert
commented
Jan 8, 2025
Comment on lines
+70
to
+76
| /** @return {Map<string, import("../models/version").default>} */ | ||
| @cached | ||
| get loadedVersionsByNum() { | ||
| let versionsRef = this.hasMany('versions'); | ||
| let values = versionsRef.value(); | ||
| return new Map(values?.map(ref => [ref.num, ref])); | ||
| } |
There was a problem hiding this comment.
I think versionsObj could also be changed to implement in this way. This would allow all versions that belong to this crate to be available, rather than just those loaded via the loadVersionsTask.
|
I have removed a commit that aimed to only await |
Turbo87
reviewed
Jan 9, 2025
eth3lbert
force-pushed
the
app-default-version
branch
from
ddfede2 to
bfe8d72
Compare
|
Rebased to make CI happy after the new Danger Zone was added :D |
eth3lbert
force-pushed
the
app-default-version
branch
from
bfe8d72 to
96786e2
Compare
This commit would ensure that `default_version` is included in the `crate` response by default. This eliminates the need to wait for the `versions` request to complete when `default_version` is the only version required.
…ame}/{version}` endpoint
Previously, we fetched all versions and then found the requested version within them. This commit changes the approach to either retrieve the version from loaded versions or fetch it from the endpoint. This change allows us to migrate to paginated versions in the future.
eth3lbert
force-pushed
the
app-default-version
branch
from
96786e2 to
433abe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would ensure that
default_versionis included in thecrateresponse by default. This eliminates the need to wait for theversionsrequest to complete whendefault_versionis the only version required. This also decouples requested version handling from versions.Related:
default_versioninclude mode #10288