Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default branch alias instead of "master" #2601

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

JohnTitor
Copy link
Member

Fixes #2599
r? @jtgeibel

@jtgeibel
Copy link
Member

jtgeibel commented Jul 5, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jul 5, 2020

📌 Commit f85767e has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Jul 5, 2020

⌛ Testing commit f85767e with merge 17eb03c...

@bors
Copy link
Contributor

bors commented Jul 5, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing 17eb03c to master...

@bors bors merged commit 17eb03c into rust-lang:master Jul 5, 2020
@JohnTitor JohnTitor deleted the default-branch branch July 5, 2020 22:15
@jplatte
Copy link

jplatte commented Jul 10, 2020

Isn't this still really weird behavior (since moving the image would break the crates.io page, and updating on the default branch updates all versions' crates.io pages)? How hard would it be, if cargo publish is ran within a git repository, to tell crates.io of the current HEAD sha and use that for the published version's relative links?

Also, would a PR adding support for other platform's URL schemes be accepted? :)

@kornelski
Copy link
Contributor

@jplatte It'd be great if Cargo fixed the URLs rust-lang/cargo#8434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't assume that default branch is named "master"
8 participants