Remove obsolete nginx wrapper #7370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
|
☔ The latest upstream changes (presumably 23d42c2) made this pull request unmergeable. Please resolve the merge conflicts. |
Turbo87
force-pushed
the
remove-nginx
branch
2 times, most recently
from
51d61c4 to
e64357e
Compare
|
This has been running in production without any issues for about a week now. I guess we can say goodbye to nginx now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2b73310 introduced nginx as a proxy in front of the app in 2014. Since then we have migrated to the https://github.com/tokio-rs/axum web framework, and were using nginx for less and less things.
At this point all of the functionality from our nginx config has been migrated into our axum server and there is nothing left for nginx to do.
Additionally, our use of nginx on Heroku also runs into heroku/heroku-buildpack-nginx#31, which causes us to drop thousands of connections on every deployment.
This PR removes the nginx wrapper and buildpack from crates.io, exposing the axum server directly to the Heroku router.
Note that I've opened this as a draft pull request for now until #7365 has run in production for a couple of days without issues :)