Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database: Add versions.yank_message column #9274

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Aug 17, 2024

ref #9193

In this PR, I added a new column to the versions table.

I picked the text here. For a simple text-based message, I think the length is enough.

I am not sure if we should consider using JSONB here to accommodate the possibility of needing to store more structured information in the future.

I also marked it private, I guess before we expose the new API to users, we should keep it private.

@Rustin170506 Rustin170506 force-pushed the rustin-patch-yank-message branch from 1dd5c45 to c9d832b Compare August 17, 2024 15:49
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506 Rustin170506 requested a review from a team August 17, 2024 16:14
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (9b88788) to head (7083232).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9274      +/-   ##
==========================================
- Coverage   89.29%   89.14%   -0.15%     
==========================================
  Files         282      283       +1     
  Lines       28629    28823     +194     
==========================================
+ Hits        25563    25693     +130     
- Misses       3066     3130      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-accounts labels Aug 19, 2024
@Turbo87 Turbo87 changed the title Add yank message migration database: Add versions.yank_message column Aug 19, 2024
@Rustin170506 Rustin170506 force-pushed the rustin-patch-yank-message branch from d7d3eab to 7083232 Compare August 20, 2024 15:43
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506 Rustin170506 requested a review from Turbo87 August 21, 2024 13:28
@Turbo87 Turbo87 merged commit 666dfcc into rust-lang:main Aug 22, 2024
10 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-yank-message branch August 22, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants