Add PATCH /crates/:crate/:version route
#9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9423 +/- ##
==========================================
+ Coverage 89.05% 89.11% +0.06%
==========================================
Files 285 285
Lines 28757 28920 +163
==========================================
+ Hits 25610 25773 +163
Misses 3147 3147 ☔ View full report in Codecov by Sentry. |
Rustin170506
force-pushed
the
rustin-patch-update-patch
branch
4 times, most recently
from
4f51afb to
629c370
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Rustin170506
force-pushed
the
rustin-patch-update-patch
branch
from
629c370 to
7dd8d49
Compare
Rustin170506
commented
Sep 11, 2024
Rustin170506
force-pushed
the
rustin-patch-update-patch
branch
3 times, most recently
from
fb5c1f2 to
30b5ddb
Compare
Turbo87
added
C-enhancement ✨
eth3lbert
reviewed
Sep 11, 2024
Turbo87
force-pushed
the
rustin-patch-update-patch
branch
from
30b5ddb to
3706791
Compare
|
I've rebased this on top of #9437 to get that first part out of the way and make the PR a bit easier to review :) |
Turbo87
force-pushed
the
rustin-patch-update-patch
branch
from
3706791 to
873ccdb
Compare
Turbo87
reviewed
Sep 12, 2024
9 tasks
Rustin170506
force-pushed
the
rustin-patch-update-patch
branch
2 times, most recently
from
f00807f to
3e33515
Compare
Rustin170506
changed the title
PATCH /crates/:crate/:version routePATCH /crates/:crate/:version route
eth3lbert
reviewed
Sep 14, 2024
Rustin170506
force-pushed
the
rustin-patch-update-patch
branch
3 times, most recently
from
a9e1768 to
5f8fbb9
Compare
Rustin170506
force-pushed
the
rustin-patch-update-patch
branch
from
5f8fbb9 to
1a9722c
Compare
Rustin170506
commented
Sep 18, 2024
Rustin170506
changed the title
PATCH /crates/:crate/:version routePATCH /crates/:crate/:version route
|
☔ The latest upstream changes (presumably #9505) made this pull request unmergeable. Please resolve the merge conflicts. |
Rustin170506
force-pushed
the
rustin-patch-update-patch
branch
5 times, most recently
from
ab6eb47 to
bdc7968
Compare
Rustin170506
commented
Sep 25, 2024
|
☔ The latest upstream changes (presumably 60d3cfe) made this pull request unmergeable. Please resolve the merge conflicts. |
Rustin170506
force-pushed
the
rustin-patch-update-patch
branch
3 times, most recently
from
23adba8 to
92a4793
Compare
Signed-off-by: Rustin170506 <[email protected]>
This was using the previous `yanked` state for the admin log message, instead of the new state.
Turbo87
reviewed
Sep 30, 2024
src/tests/krate/yanking.rs
Outdated
Comment on lines
277
to
288
| // Attempt to set yank message on unyanked version (should fail) | ||
| token | ||
| .update_yank_status("patchable", "1.0.0", None, Some("Invalid message")) | ||
| .await | ||
| .status() | ||
| .is_client_error(); | ||
| // Attempt to unyank with message (should fail) | ||
| token | ||
| .update_yank_status("patchable", "1.0.0", Some(false), Some("Invalid message")) | ||
| .await | ||
| .status() | ||
| .is_client_error(); |
There was a problem hiding this comment.
these calls just return bool, but they are missing assertions. probably best to assert against a specific status code though.
src/controllers/version/metadata.rs
Outdated
|
|
||
| if Handle::current().block_on(user.rights(state, &owners))? < Rights::Publish { | ||
| if user.is_admin { | ||
| let action = if version.yanked { |
There was a problem hiding this comment.
I think this should be using the yanked variable from below 🤔
Turbo87
force-pushed
the
rustin-patch-update-patch
branch
from
92a4793 to
45ec3fb
Compare
|
I rebased the branch and fixed the above two comments. I think this is good to go now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9193
This pull request introduces a new patch API for yanking and unyanking crates with a message.
The logic is very similar to the current yank and unyank API, but it supports setting a yank message.