Resurrect CBOR index handling and migration, update to migrate failed builds #2187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some errors logged saying that the index wasn't a sqlite database: https://rust-lang.sentry.io/issues/4382204513/events/6c800157e8484ad893508b75745255a2/
For the impacted crates trying to browse their source files also didn't work, the list was there (since that's stored in the database) but none of the files showed source code.
Investigating on the server we can see that the index files are not a database file, they're still in the CBOR encoding:
This only impacts crates that failed to build, because I suggested those be filtered out from migrating to avoid the error when their rustdoc-archive didn't exist, but they still have the source-archive that needs migrating.
This PR reverts the CBOR index removal, and updates the migration to also attempt migrating crates that failed to build, and doesn't report the index not existing as an error.