Don't report errors getting readme when manifest is missing #2188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Aug 10, 2023
syphar
reviewed
Aug 12, 2023
|
@Nemo157 do you think you have time to finish this up? if not, I'll merge it and write a test in a separate PR. |
|
I will, but probably not till next week, currently biking to a conference and having issues trying to ssh into my dev server. |
Nemo157
force-pushed
the
missing-sources
branch
from
7a25ea7
to
fb48d5b
Compare
|
Found a couple minutes to add a test. |
Nemo157
force-pushed
the
missing-sources
branch
from
fb48d5b
to
64615ce
Compare
syphar
approved these changes
Aug 26, 2023
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
|
Sentry issue: DOCS-RS-BACKEND-5P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops reporting of https://rust-lang.sentry.io/share/issue/4c65524a03f84ac19d295eda11d442c3/
It seems like at some point we had some crates get added without their corresponding source files being stored.