Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "About" link point to current website and not open in a new tab #2219

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

GuillaumeGomez
Copy link
Member

When I was working on #2218, I realized (after some time...) that it was actually redirecting me to docs.rs every time and not simply use my local instance.

So this PR changes two things:

  1. Use a relative URL instead of pointing to docs.rs.
  2. Since it's the same website, not open this link into a new tab.

@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Sep 14, 2023
@syphar
Copy link
Member

syphar commented Sep 15, 2023

I like the change, will approve after testing when I'm back next week

@syphar syphar merged commit 2dc3593 into rust-lang:master Sep 20, 2023
7 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Sep 20, 2023
@GuillaumeGomez GuillaumeGomez deleted the about-link branch September 20, 2023 08:39
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants