-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more build states #2422
Merged
Merged
add more build states #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphar
added
the
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
label
Feb 21, 2024
github-actions
bot
added
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Feb 21, 2024
syphar
added
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
and removed
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
labels
Feb 21, 2024
syphar
force-pushed
the
more-build-states
branch
5 times, most recently
from
February 21, 2024 13:48
07a121d
to
f3d0200
Compare
syphar
force-pushed
the
more-build-states
branch
3 times, most recently
from
March 1, 2024 15:31
3bb56b9
to
3e26e34
Compare
syphar
force-pushed
the
more-build-states
branch
10 times, most recently
from
March 10, 2024 06:12
f778f90
to
3fa0c23
Compare
syphar
force-pushed
the
more-build-states
branch
from
March 10, 2024 06:14
3fa0c23
to
ad12d7f
Compare
syphar
added
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Mar 10, 2024
syphar
force-pushed
the
more-build-states
branch
from
March 10, 2024 06:18
ad12d7f
to
066aa37
Compare
@Nemo157 I think this is ready for a first review. I tried to take your commits and adapt them to sqlx first, and then started to add commits onto these. For a review commit-by-commit is probably best, comparing to your commits too. |
GuillaumeGomez
approved these changes
Mar 10, 2024
Changes look good to me, but as usual, please wait for someone else's review before merging. |
Nemo157
approved these changes
Mar 11, 2024
github-actions
bot
added
S-waiting-on-deploy
This PR is ready to be merged, but is waiting for an admin to have time to deploy it
and removed
S-waiting-on-review
Status: This pull request has been implemented and needs to be reviewed
labels
Mar 11, 2024
syphar
removed
the
S-waiting-on-deploy
This PR is ready to be merged, but is waiting for an admin to have time to deploy it
label
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is picking up from the work by @Nemo157, working towards solving #1011 ( and a bunch of other related issues).
I went through all places I found where we access a
.build_status
, and I believe we need a new "aggregated" build status for a release, which would be:In my mind, most of the site doesn't care about in-progress builds, and only cares about failed builds when there is no successful one. We can later opt-in into showing more when we want to.
I've put the logic into a database view, so now we can use it not only when fetching single releases, but also when we fetch release lists.
It would be awesome for the reviewer to do the same check for the usages and if my assumption is correct.
Currently we don't have in-progress builds anywhere, but when we have, we'll have to revisit each handler/view anyways and decide if and how we show in-progress builds or releases.
The next PR then would be to start adding in-progress crates, releases & builds and then checking everything again.