Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more build states #2422

Merged
merged 11 commits into from
Mar 11, 2024
Merged

add more build states #2422

merged 11 commits into from
Mar 11, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Feb 21, 2024

This is picking up from the work by @Nemo157, working towards solving #1011 ( and a bunch of other related issues).

I went through all places I found where we access a .build_status, and I believe we need a new "aggregated" build status for a release, which would be:

  • "successful" if there is any successful build, because then we have docs to show, and newer failed or in-progress builds don't change that.
  • then, "failed" when there is any failed build
  • the rest is in progress

In my mind, most of the site doesn't care about in-progress builds, and only cares about failed builds when there is no successful one. We can later opt-in into showing more when we want to.

I've put the logic into a database view, so now we can use it not only when fetching single releases, but also when we fetch release lists.
It would be awesome for the reviewer to do the same check for the usages and if my assumption is correct.

Currently we don't have in-progress builds anywhere, but when we have, we'll have to revisit each handler/view anyways and decide if and how we show in-progress builds or releases.

The next PR then would be to start adding in-progress crates, releases & builds and then checking everything again.

@syphar syphar added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Feb 21, 2024
@github-actions github-actions bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Feb 21, 2024
@syphar syphar added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Feb 21, 2024
@syphar syphar force-pushed the more-build-states branch 5 times, most recently from 07a121d to f3d0200 Compare February 21, 2024 13:48
@syphar syphar self-assigned this Feb 21, 2024
@syphar syphar force-pushed the more-build-states branch 3 times, most recently from 3bb56b9 to 3e26e34 Compare March 1, 2024 15:31
@syphar syphar force-pushed the more-build-states branch 10 times, most recently from f778f90 to 3fa0c23 Compare March 10, 2024 06:12
@syphar syphar changed the title WIP: more build states add more build states Mar 10, 2024
@syphar syphar added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Mar 10, 2024
@syphar
Copy link
Member Author

syphar commented Mar 10, 2024

@Nemo157 I think this is ready for a first review.

I tried to take your commits and adapt them to sqlx first,

and then started to add commits onto these.

For a review commit-by-commit is probably best, comparing to your commits too.

@syphar syphar marked this pull request as ready for review March 10, 2024 06:19
@syphar syphar requested a review from a team as a code owner March 10, 2024 06:19
@GuillaumeGomez
Copy link
Member

Changes look good to me, but as usual, please wait for someone else's review before merging.

@syphar syphar requested a review from Nemo157 March 11, 2024 06:14
@syphar syphar merged commit 7048b2a into rust-lang:master Mar 11, 2024
12 checks passed
@syphar syphar deleted the more-build-states branch March 11, 2024 18:53
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Mar 11, 2024
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants