Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #2701

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Spelling #2701

merged 1 commit into from
Jan 1, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 30, 2024

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/docs.rs/actions/runs/12547208784#summary-34984279433

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/docs.rs/actions/runs/12547209701#summary-34984281028

@jsoref jsoref requested a review from a team as a code owner December 30, 2024 13:29
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Dec 30, 2024
Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to drop anything... If there are specific upstreams for things, I can try to send them PRs as well...

assets/syntaxes/Packages/D/tests/syntax_test_d.d Outdated Show resolved Hide resolved
assets/syntaxes/Packages/D/Completion Rules.tmPreferences Outdated Show resolved Hide resolved
assets/syntaxes/Packages/PHP/PHP.sublime-completions Outdated Show resolved Hide resolved
assets/syntaxes/Packages/PHP/PHP.sublime-completions Outdated Show resolved Hide resolved
assets/syntaxes/Packages/Perl/Perl.sublime-syntax Outdated Show resolved Hide resolved
assets/syntaxes/Packages/XML/syntax_test_xml.xml Outdated Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
@syphar
Copy link
Member

syphar commented Dec 30, 2024

I'm happy to drop anything... If there are specific upstreams for things, I can try to send them PRs as well...

hi, thanks for the fixes! I'm on sick leave right now, so can't go through it in detail yet,

first thing: assets/syntaxes/ is copied from an external source, so please leave it unchanged. I need to look up where it came from, I think it is documented somewhere

@jsoref
Copy link
Contributor Author

jsoref commented Dec 30, 2024

It looks like assets/syntaxes/Packages ~ https://github.com/sublimehq/Packages, so I'll start there ...

@GuillaumeGomez
Copy link
Member

Looks all good to me, please squash your commits and then I merge.

@jsoref
Copy link
Contributor Author

jsoref commented Dec 30, 2024

Any preference on commit message?

@GuillaumeGomez
Copy link
Member

"Fix typos/spellings"?

Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Dec 31, 2024

@GuillaumeGomez done

@GuillaumeGomez
Copy link
Member

Looks good to me, thanks! Just gonna wait for @syphar to confirm all changes are ok before merging.

@syphar
Copy link
Member

syphar commented Jan 1, 2025

awesome, thanks!

@syphar syphar merged commit b8d17ed into rust-lang:master Jan 1, 2025
13 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 1, 2025
@jsoref jsoref deleted the spelling branch January 1, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants