Add esp32s2 to no CAS list #2805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
MabezDev
force-pushed
the
add-esp32-to-no-cas-list
branch
from
11701c2 to
9b215f5
Compare
MabezDev
force-pushed
the
add-esp32-to-no-cas-list
branch
from
9b215f5 to
7668fee
Compare
|
Thanks for the PR. I would prefer not to accept a way to manually manage such a list of platforms. I've said this many times in other repos like crossbeam-rs/crossbeam#751 (review), crossbeam-rs/crossbeam#937 (comment). Instead, I would accept a patch to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this entry, esp32s2 users with
futures-*dependencies in their tree, indirectly or not must somehow enable the portable atomic feature. This change makes it seamless like it is on RISCV etc.