Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Binding public #940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ pub use crate::tracing::{trace_set, TraceLevel};
pub use crate::transaction::Transaction;
pub use crate::tree::{Tree, TreeEntry, TreeIter, TreeWalkMode, TreeWalkResult};
pub use crate::treebuilder::TreeBuilder;
pub use crate::util::IntoCString;
pub use crate::util::{Binding, IntoCString};
pub use crate::version::Version;
pub use crate::worktree::{Worktree, WorktreeAddOptions, WorktreeLockStatus, WorktreePruneOptions};

Expand Down
16 changes: 15 additions & 1 deletion src/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,27 @@ impl<T> IsNull for *mut T {
}
}

#[doc(hidden)]
/// Provides access to the raw libgit2 pointer to be able to interact with libgit2-sys.
///
/// If you are going to depend on this trait on your code, do consider contributing to the git2
/// project to add the missing capabilities to git2.
pub trait Binding: Sized {
/// The raw type that allows you to interact with libgit2-sys.
type Raw;

/// Build a git2 struct from its [Binding::Raw] value.
unsafe fn from_raw(raw: Self::Raw) -> Self;

/// Access the [Binding::Raw] value for a struct.
///
/// The returned value is only safe to use while its associated git2 struct is in scope.
/// Once the associated git2 struct is destroyed, the raw value can point to an invalid memory address.
fn raw(&self) -> Self::Raw;

/// A null-handling version of [Binding::from_raw].
///
/// If the input parameter is null, then the funtion returns None. Otherwise, it
/// calls [Binding::from_raw].
unsafe fn from_raw_opt<T>(raw: T) -> Option<Self>
where
T: Copy + IsNull,
Expand Down