Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for grammer interning tree-like field structure. #133

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Update for grammer interning tree-like field structure. #133

merged 1 commit into from
Aug 29, 2019

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 27, 2019 •
edited
Loading

@eddyb eddyb mentioned this pull request Aug 27, 2019
Merged
@eddyb eddyb requested a review from CAD97 August 27, 2019 15:34
CAD97
CAD97 approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@CAD97 CAD97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM

src/generate/rust.rs

quote!(#(
quote!(#(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indent seems accidental

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, rustfmt just didn't indent anything inside the invocation.

@eddyb eddyb merged commit 2774766 into rust-lang:master Aug 29, 2019
@eddyb eddyb deleted the tree-fields branch August 29, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAD97 CAD97 CAD97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyb @CAD97