Avoid unwrap() if non UTF-8 in the require_literal_leading_dot flow #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the path if UTF-8 validation fails and is required for string comparison, instead of crashing.
Add a test exhibiting the problem (fixed with this change).
Note that with
require_literal_leading_dot: false
, I could get results that have non utf-8 path components; withrequire_literal_leading_dot: true
it panics without the patch, and filters those paths with it (I think that it makes more sense to filter out paths that we're unsure if should be filtered in).An alternative is to use bytes comparison:
but I think that it's not a good idea to add half-done utf-8 handling. Instead, let's wait for proper support across the crate.
Btw, the rust issue rust-lang/rust#9639 is referenced around here - perhaps we should create a tracking issue in this repository and update the references?