Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pthread_set_name_np from NuttX #4251

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Jan 24, 2025

Description

Removed pthread_set_name_np function from the NuttX bindings as it does not exist in the NuttX API, this change aligns the code with the actual NuttX implementation

Sources

https://github.com/apache/nuttx/blob/8f3a2a6f7645dd95b6a7608b9cde3cb693b118c2/include/pthread.h#L511-L514

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35
Copy link
Contributor

LGTM, blocked on #4254 for CI fixes.

Removed `pthread_set_name_np` function from the NuttX bindings as it does not exist in the NuttX API,
this change aligns the code with the actual NuttX implementation

Signed-off-by: Huang Qi <[email protected]>
@tgross35 tgross35 enabled auto-merge February 5, 2025 11:15
@tgross35 tgross35 added this pull request to the merge queue Feb 5, 2025
auto-merge was automatically disabled February 5, 2025 11:44

Pull Request is not mergeable

Merged via the queue into rust-lang:main with commit 478f19d Feb 5, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants