Skip to content

Add constants for Memory-Deny-Write-Execute prctls #4400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025

Conversation

rusty-snake
Copy link
Contributor

Description

This PR adds constants for Memory-Deny-Write-Execute prctls added in Linux 6.3 (PR_MDWE_NO_INHERIT Linux 6.6).

Sources

https://github.com/torvalds/linux/blob/3bde70a2c82712f05c7220b8b94fc2cbdf7fbfe0/include/uapi/linux/prctl.h#L287-L292

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 12, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-linux O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 12, 2025
@rusty-snake
Copy link
Contributor Author

I'm not sure if the CI failure is because architecture or libc.

@tgross35
Copy link
Contributor

It's probably just that everything in CI running musl is very outdated, I assume they should be available since they are uapi. Cc @maurer in case that is not accurate.

Assuming it's just a CI thing, you can update libc-test/build.rs to skip these on the relevant platform.

@rustbot author

@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rusty-snake rusty-snake force-pushed the prctl-mdwe branch 3 times, most recently from 4cf57ec to b8e262e Compare May 1, 2025 09:30
@rusty-snake
Copy link
Contributor Author

@rustbot ready

@tgross35
Copy link
Contributor

tgross35 commented May 3, 2025

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tgross35 tgross35 added this pull request to the merge queue May 3, 2025
Merged via the queue into rust-lang:main with commit 76baec6 May 3, 2025
49 of 50 checks passed
@rusty-snake rusty-snake deleted the prctl-mdwe branch May 3, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-linux O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants