Skip to content

Add strerror_r function to nuttx system (version 0.2.174) #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fxdmhtt
Copy link

@fxdmhtt fxdmhtt commented Jul 26, 2025

Description

Line 69 of nuttx/include/string.h file:

int        strerror_r(int, FAR char *, size_t);

not exposed in libc, causing rustix compilation exception.

Sources

https://github.com/apache/nuttx/blob/0f73f92ffce74f349aecbe2a20adc69f2d84c601/include/string.h#L69

Checklist

This PR is not a breaking change.

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2025

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in the Android module

cc @maurer

Some changes occurred in OpenBSD module

cc @semarie

@tgross35
Copy link
Contributor

Did you perhaps branch off of the libc-0.2 branch but submit a PR against main?

@fxdmhtt fxdmhtt changed the base branch from main to libc-0.2 July 26, 2025 09:39
@fxdmhtt
Copy link
Author

fxdmhtt commented Jul 26, 2025

Did you perhaps branch off of the libc-0.2 branch but submit a PR against main?

I'm very sorry, I have edited it.

@tgross35
Copy link
Contributor

Wrong way; please branch from and target main :)

@fxdmhtt
Copy link
Author

fxdmhtt commented Jul 26, 2025

Wrong way; please branch from and target main :)

I just hope to make a patch to 0.2.174 and release 0.2.175 in due course, otherwise I will close this PR.

@tgross35
Copy link
Contributor

Everything targets main by default so we don't lose the changes once 1.0 gets released. You can add the stable-nominated label to request a backport (usually I add the label to everything possible if it gets missed)

@fxdmhtt
Copy link
Author

fxdmhtt commented Jul 26, 2025

Ok, I'll commit next time when I have more changes merged.

@tgross35
Copy link
Contributor

No need; the change here is fine, you just need to rebase on top of main (and change the PR target branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants