Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newlib fmodf #174

Closed
wants to merge 7 commits into from
Closed

Add newlib fmodf #174

wants to merge 7 commits into from

Conversation

tesuji
Copy link

@tesuji tesuji commented May 26, 2019 •
edited
Loading

@tesuji
Copy link
Author

tesuji commented May 27, 2019

Build failed because of #170

@tesuji tesuji force-pushed the fmodf branch 4 times, most recently from 65a5143 to 70fa7ef Compare May 27, 2019 10:01
@alexcrichton
Copy link
Member

Thanks for the PR! I have the same questions as #169 for this though. Why is this change being made relative to what's currently already implemented?

@Schultzer Schultzer mentioned this pull request Jul 5, 2019
Closed
@tesuji
Copy link
Author

tesuji commented Nov 25, 2019

Seems like we don't agree the merge this. Closing then.

@tesuji tesuji closed this Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tesuji @alexcrichton