Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Add cr_hypot from core-math #322

Closed
wants to merge 1 commit into from
Closed

Add cr_hypot from core-math #322

wants to merge 1 commit into from

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Oct 26, 2024 •
edited
Loading

ci: allow-regressions

@tgross35
Copy link
Contributor Author

🎉 I honestly cannot believe that a second algorithm ported that easily

@tgross35 tgross35 force-pushed the core-hypot branch 2 times, most recently from d4ab195 to e22badf Compare February 12, 2025 02:28
@tgross35
Copy link
Contributor Author

tgross35 commented Feb 12, 2025 •
edited
Loading

Softfloat is woah

icount::icount_bench_hypot_group::icount_bench_hypot logspace:setup_hypot()
Performance has regressed: Instructions (111909 > 24485) regressed by +357.051% (>+5.00000)
  Baselines:                      softfloat|softfloat
  Instructions:                      111909|24485                (+357.051%) [+4.57051x]
  L1 Hits:                           128227|27068                (+373.722%) [+4.73722x]
  L2 Hits:                                8|4                    (+100.000%) [+2.00000x]
  RAM Hits:                              52|25                   (+108.000%) [+2.08000x]
  Total read+write:                  128287|27097                (+373.436%) [+4.73436x]
  Estimated Cycles:                  130087|27963                (+365.211%) [+4.65211x]

@tgross35
Copy link
Contributor Author

tgross35 commented Feb 12, 2025 •
edited
Loading

Hardfloat

icount::icount_bench_hypot_group::icount_bench_hypot logspace:setup_hypot()
Performance has regressed: Instructions (39795 > 21041) regressed by +89.1307% (>+5.00000)
  Baselines:                      hardfloat|hardfloat
  Instructions:                       39795|21041                (+89.1307%) [+1.89131x]
  L1 Hits:                            50851|23342                (+117.852%) [+2.17852x]
  L2 Hits:                                3|4                    (-25.0000%) [-1.33333x]
  RAM Hits:                              24|13                   (+84.6154%) [+1.84615x]
  Total read+write:                   50878|23359                (+117.809%) [+2.17809x]
  Estimated Cycles:                   51706|23817                (+117.097%) [+2.17097x]

Overall, seems fairly reasonable. More optimizations are probably feasible.

@tgross35 tgross35 mentioned this pull request Feb 12, 2025
Closed
@tgross35
Copy link
Contributor Author

Recreated as rust-lang/compiler-builtins#859

@tgross35 tgross35 closed this Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tgross35