Allow using vcpkg for all Windows targets, and use find_package #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vcpkg-rs
doesn't support-pc-windows-gnu
(mingw) yet, but its integration tests will try to buildlibz-sys
, which currently prevents usingvcpkg
for non-msvc
targets.This change should have no effect for
libz-sys
right now, but unblocks that work.This also switches from
vcpkg::lib_names
/probe
tovcpkg::find_package
, which reliably gets the library names. Previously, this had hard coded assumptions using MSVC-style library naming (nolib
prefix).Addendum to release notes:
vcpkg
won't work for non-MSVC Windows targets until mcgoo/vcpkg-rs#52 is merged and there's a release ofvcpkg-rs
with that PR.