Support right-to-left languages #1489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to say that, with the exception of the |
Replace phyiscal properties (top/bottom/left/right) with logical properties (start/end) that can be used in non-LTR contexts (e.g., content in Arabic or Hebrew). Based on the CSS Logical Properties and Values Level 1 specification, currently an Editor's Draft [1]. Referencing MDN, all major browsers except Internet Explorer support the margin, padding, and border properties. [1]: https://drafts.csswg.org/css-logical/ Signed-off-by: Tim Crawford <[email protected]>
This will be necessary for using CSS selectors on root attributes. Signed-off-by: Tim Crawford <[email protected]>
Fix behavior of some elements when displaying page in RTL. Signed-off-by: Tim Crawford <[email protected]>
|
I tested the latest changes and my previous comment still holds. Thanks for the effort! 🖖 |
|
Adding my support for merging this PR, please! Thanks for your work @crawfxrd :) |
|
Additional changes were made in #1641 to better support the configuration. I don't know if @cN3rd is active to rebase that, but that is what should be tested at this point. Considering neither received any feedback, I will probably just close mine. I don't use any RTL languages, so don't have a reason to push for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CSS logical properties where feasible and CSS selectors elsewhere to fix behavior of RTL pages. Moves
js/no-jsandsidebar-hidden/sidebar-visibleclasses from the roothtmlelement tobodyso that selectors function correctly when page direction is flipped.TODO:
dir="rtl"explicitly?Resolves: #1486