fix: themes broken when localStorage has invalid theme id stored #2463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2461
Check if stored theme is valid in
get_theme()
and defaults to default theme if not valid.Validation steps:
cargo run -- build guide
and serve the booklocalStorage.setItem("mdbook-theme", "foo")
to set an invalid themefoo
Manually tested in Google Chrome, MS Edge and Firefox (I don't have access to safari :(
Other:
localStorage
won't be updated (i.e. keeps the invalid value) until user manually changes the theme