Extern crate #2503
Open
Extern crate #2503
+617
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… overoptimize compile time.
Also refactor the `mdBook test` section and add a new "writing doc tests" chapter.
|
I'm dependent on feature file_set_times, which was stabilized in rust v 1.76. You are currently on 1.74. What is the schedule for updating your MSRV? |
… project: changed config rust.package-dir to rust.manifest
and preferring [rust.manifest] over [rust.edition].
make chap Alternate Backends pass doctest.
|
Functionally, I think this PR is now stable and ready for review (and general use). |
Prefer edition setting from Cargo.toml over book.toml; sadly, Cargo also overrides command line.
juli-99
reviewed
Dec 30, 2024
guide/src/guide/README.md
Outdated
| @@ -4,4 +4,4 @@ This user guide provides an introduction to basic concepts of using mdBook. | |||
|
|
|||
| - [Installation](installation.md) | |||
| - [Reading Books](reading.md) | |||
| - [Creating a Book](creating.md) | |||
|
In fixing above issues, I noticed that there were clippy nags in several files that hadn't been raised by CI. I've fixed the ones in files I modified and could fix the remaining ones if needed, but I don't know why CI doesn't flag them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows doc tests to freely reference external crates in
usestatements.Avoids depending on unstable Cargo interfaces to determine dependencies by the
simple expedient of running a
cargo build --verboseand observing how Cargo invoked the compiler.Includes necessary doc changes and some gratuitous rewrites as well.
Fixes #706 and #394.
Edit: does not address issue 768.
Edit: With the latest batch of commits, all doctests in the
mdbookproject now work.