Only load searchindex when needed #2553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're going to mess with the search engine, can you also write some gui tests that exercise it? |
|
Very good point. |
GuillaumeGomez
force-pushed
the
load-on-need
branch
from
8ab48db to
8b5125d
Compare
|
Added the GUI test. :) |
notriddle
reviewed
Feb 21, 2025
| @@ -2,9 +2,6 @@ | |||
| // an iframe (because of JS disabled). | |||
| // Regression test for <https://github.com/rust-lang/mdBook/issues/2528>. | |||
|
|
|||
| // We disable the requests checks because `searchindex.json` will always fail | |||
| // locally. | |||
| fail-on-request-error: false | |||
GuillaumeGomez
force-pushed
the
load-on-need
branch
from
e3244b2 to
16cbfd6
Compare
|
When the JS is being retrieved, there is now a spinner and the input is not disabled anymore:
|
notriddle
approved these changes
Feb 21, 2025
GuillaumeGomez
force-pushed
the
load-on-need
branch
from
16cbfd6 to
38b4ea7
Compare
GuillaumeGomez
force-pushed
the
load-on-need
branch
from
38b4ea7 to
c96b7e4
Compare
|
Rebased and fixed merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit comes from #2552.
This PR makes it so that the
searchindex.jsfile is only loaded when the user arrives on a page with?search=in the URL or if the user opens the search.cc @notriddle