Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint warnings and add eslint check in CI #2554

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix eslint warnings and add eslint check in CI #2554

wants to merge 3 commits into from

Conversation

GuillaumeGomez
Copy link
Member

First commit comes from #2552.

This PR fixed all eslint warnings and added it as a check in the CI. That is a first step in improving the JS quality.

cc @notriddle

@GuillaumeGomez GuillaumeGomez requested a review from ehuss February 21, 2025 22:14
@rustbot rustbot added the S-waiting-on-review Status: waiting on a review label Feb 21, 2025
@GuillaumeGomez
Copy link
Member Author

Rebased and fixed merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss Awaiting requested review from ehuss

Assignees
No one assigned
Labels
S-waiting-on-review Status: waiting on a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeGomez @rustbot