fix error returned from readdir_r when isolation is enabled, and uses of raw_os_error #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
changed the title
RalfJung
commented
Oct 26, 2024
saethlin
approved these changes
Oct 26, 2024
|
Thanks. :) Could you also press the "merge" button? I am on mobile and do not have access right now.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3779 @oli-obk noticed that our
readdir_ris buggy -- it shouldn't ever set errno, but the "isolation enabled" path used the shared helper that sets errno.So this PR fixes that. I think that is the only part of #3779 that intentionally changes behavior.
I also noticed some uses of raw_os_error, which is buggy since it returns host error codes that we can't just use for the target.