[WIP] blocking unnamed_socket #4072
Draft
+134
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-author
|
Planning to open a minor clean-up PR to remove some unused variable here before getting back to this. @rustbot label S-blocked |
|
☔ The latest upstream changes (presumably #4074) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
reviewed
Dec 6, 2024
oli-obk
reviewed
Dec 6, 2024
tiif
commented
Dec 10, 2024
| @@ -171,82 +167,143 @@ impl FileDescription for AnonSocket { | |||
| } | |||
|
|
|||
| /// Write to AnonSocket based on the space available and return the written byte size. | |||
| /// This is only for socketpair/pipe without O_NONBLOCK flag. | |||
There was a problem hiding this comment.
Just something on top of my mind while working on this, if we were to support O_NONBLOCK flag in fcntl, which has the ability of setting a file descriptor with blocking ability to non-blocking, we need to be careful of it's interaction with all the blocking operation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very WIP PR opened to ask for some feedback.
TODO:
@rustbot author