Add support for vectorized read/write with libc::readv and libc::writev #4084
+232
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shamb0
commented
Dec 10, 2024
shamb0
commented
- This enables vectorized read & write
shamb0
force-pushed
the
support-libc-readv-writev
branch
from
629865a to
195ddfe
Compare
- This enables vectorized reads. Signed-off-by: shamb0 <[email protected]>
shamb0
force-pushed
the
support-libc-readv-writev
branch
from
195ddfe to
144a986
Compare
RalfJung
reviewed
Dec 12, 2024
There was a problem hiding this comment.
I'll assume this should not be reviewed yet since it is marked as a draft. I just noticed this one small thing. ;)
I'd recommend to make a first PR with just readv. Smaller PRs are always easier to handle. Please write @rustbot ready and remove the "draft" status once you want a review.
| let [fd, iov, iovcnt] = this.check_shim(abi, ExternAbi::C { unwind: false }, link_name, args)?; | ||
| let fd = this.read_scalar(fd)?.to_i32()?; | ||
| let iovcnt = this.read_scalar(iovcnt)?.to_i32()?; | ||
| this.readv(fd, iov, iovcnt as _, None, dest)?; |
There was a problem hiding this comment.
Please don't use as casts. Why are you casting here anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.