Skip to content

Replace _mm_movemask_pi8 with the fallback_impl #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

Stupremee
Copy link
Member

_mm_movemask_pi8 got removed from stdarch and there is no real alternative (_mm_movemask_epi8 that was suggested here doesn't take a 64bit wide vector but a 128bit vector instead) .

Resolves #288

This has to be done, because `_mm_movemask_pi8` got removed
from stdarch in rust-lang/stdarch#890
@Stupremee
Copy link
Member Author

Stupremee commented Sep 22, 2020

I just noticed that there are much more mmx occurrences, but this pr should still make #289 work

@workingjubilee
Copy link
Member

This appears to build now! Excellent, thank you.

@workingjubilee workingjubilee merged commit 4d823d1 into rust-lang:master Sep 23, 2020
@Stupremee Stupremee deleted the fix-missing-mmx branch September 23, 2020 18:43
@mati865
Copy link
Contributor

mati865 commented Sep 23, 2020

Still doesn't build:

error[E0432]: unresolved import `crate::arch::x86_64::_mm_shuffle_pi8`
   --> /home/travis/build/rust-lang/packed_simd/src/codegen/shuffle1_dyn.rs:40:29
    |
40  |                         use crate::arch::x86_64::_mm_shuffle_pi8;
    |                             ^^^^^^^^^^^^^^^^^^^^^---------------
    |                             |                    |
    |                             |                    help: a similar name exists in the module: `_mm_shuffle_epi8`
    |                             no `_mm_shuffle_pi8` in `arch::x86_64`
...
297 | impl_shuffle1_dyn!(u8x8);
    | ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

@workingjubilee
Copy link
Member

Fixing that in #292! I think I meant "with two more modifications" at the time but I had just begun the process of hammering away at a million lints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation Failure on nightly-2020-09-15
3 participants