add armv7 target #42
add armv7 target #42
Conversation
|
Alas it succeeds 🙃 |
|
I'm hoping to replicate the CI setup from https://github.com/rust-lang/stdarch/ and/or https://github.com/rust-lang/packed_simd this weekend, which (if successful) will help here. That said looking at what you have there, I think you're running on arm64 which is armv8, no? |
| - name: "armv7-unknown-linux-gnueabihf (neon)" | ||
| os: linux | ||
| arch: arm64 | ||
| env: RUSTFLAGS=-Ctarget-feature=+neon |
There was a problem hiding this comment.
Adding +neon after the fact to the armv7-unknown-linux-gnueabihf target results in terrible performance due to the mismatch between the pre-built std and what's being built with +neon.
The target that doesn't suffer from this problem is thumbv7neon-unknown-linux-gnueabihf, which bakes the neon option into the target definition and, therefore, comes with neon-enabled std.
|
@thomcc I believe so yes, but am not super familiar with ARM so am deferring to you on it 😄 I was curious to see if I could quickly make it fail the same way in CI for us. I should have signaled better than this was a quick experiment, and will go ahead and close this. |
In #41 I ran into some test case failures with ARMv7 on a Raspberry Pi. I'm just opening this up to see if I can replicate those on the targets available to use in CI.