Use platform intrinsics, not LLVM, for floor & ceil #47

workingjubilee · 2020-12-01T03:34:58Z

This PR removes the direct linkage to LLVM for trunc and round intrinsics, while replacing that link with rustc's platform intrinsics for floor and ceil functions, namely simd_floor and simd_ceil. Tests that are no longer testable are removed. In doing so it resolves the riscv64gc compilation problems.

This PR will close #35.

This reverts commit 3ad356d.

There are no platform intrinsics in the rustc for these functions yet, so this removes them as a distinct commit for later reversion.

workingjubilee · 2020-12-01T04:00:33Z

This is blocked on rust-lang/rust#79560, indeed the entire library might be.

workingjubilee · 2020-12-04T02:46:50Z

This is no longer blocked. Please disregard Travis' "pull request' failure, it was based on the spurious error from before.

workingjubilee · 2020-12-04T02:59:03Z

Huh, there is a further issue but only with the mask types on wasm SIMD. I assume this was not introduced by this patch, so there should be no reason not to merge this.

big fat error log

failures:

---- ops::ops_impl::mask128::mask128x4::bitand output ----

error output:

    panicked at 'assertion failed: `(left == right)`

      left: `[false (0), false (0), false (0), true (ffffffffffffffffffffffffffffffff)]`,

     right: `[false (0), false (0), true (ffffffffffffffff), true (ffffffffffffffffffffffffffffffff)]`', crates/core_simd/tests/ops_impl/mask128.rs:4:1

    

    Stack:

    

    Error

        at http://127.0.0.1:45623/wasm-bindgen-test:578:19

        at http://127.0.0.1:45623/wasm-bindgen-test:154:22

        at console_error_panic_hook::hook::h8a744eaa07f313f0 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[3580]:0x231cd6)

        at core::ops::function::Fn::call::h8d9f8d3764bff0d3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[14961]:0x3e4466)

        at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x3635f3)

        at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

        at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

        at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

        at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

        at ops::ops_impl::mask128::mask128x4::bitand::h71eb62a9f2d1b01d (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[265]:0x7290b)

    

    



JS exception that was thrown:

    RuntimeError: unreachable

        at __rust_start_panic (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[14994]:0x3e4581)

        at rust_panic (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12377]:0x3da900)

        at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x36361a)

        at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

        at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

        at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

        at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

        at ops::ops_impl::mask128::mask128x4::bitand::h71eb62a9f2d1b01d (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[265]:0x7290b)

        at <wasm_bindgen_test::__rt::TestFuture<F> as core::future::future::Future>::poll::{{closure}}::{{closure}}::hae6ed923cee3795b (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[11445]:0x3c7e5b)

        at wasm_bindgen::convert::closures::invoke0_mut::hd679e8cfa73e2075 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12410]:0x3daddb)

---- ops::ops_impl::mask128::mask128x4::bitand_assign output ----

error output:

    panicked at 'assertion failed: `(left == right)`

      left: `[false (0), false (0), false (0), true (ffffffffffffffffffffffffffffffff)]`,

     right: `[false (0), false (0), true (ffffffffffffffff), true (ffffffffffffffffffffffffffffffff)]`', crates/core_simd/tests/ops_impl/mask128.rs:4:1

    

    Stack:

    

    Error

        at http://127.0.0.1:45623/wasm-bindgen-test:578:19

        at http://127.0.0.1:45623/wasm-bindgen-test:154:22

        at console_error_panic_hook::hook::h8a744eaa07f313f0 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[3580]:0x231cd6)

        at core::ops::function::Fn::call::h8d9f8d3764bff0d3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[14961]:0x3e4466)

        at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x3635f3)

        at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

        at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

        at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

        at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

        at ops::ops_impl::mask128::mask128x4::bitand_assign::hc476ffd786a33543 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[268]:0x733fd)

    

    



JS exception that was thrown:

    RuntimeError: unreachable

        at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x363614)

        at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

        at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

        at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

        at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

        at ops::ops_impl::mask128::mask128x4::bitand_assign::hc476ffd786a33543 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[268]:0x733fd)

        at <wasm_bindgen_test::__rt::TestFuture<F> as core::future::future::Future>::poll::{{closure}}::{{closure}}::h73958fc516e56f26 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[10941]:0x3bcd32)

        at wasm_bindgen::convert::closures::invoke0_mut::hd679e8cfa73e2075 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12410]:0x3daddb)

        at __wbg_adapter_31 (http://127.0.0.1:45623/wasm-bindgen-test:272:10)

        at cb0 (http://127.0.0.1:45623/wasm-bindgen-test:438:28)

---- ops::ops_impl::mask128::mask128x4::bitor output ----

JS exception that was thrown:

    RuntimeError: unreachable

        at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x363614)

        at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

        at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

        at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

        at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

        at ops::ops_impl::mask128::mask128x4::bitor::h4b1e89598caa7d84 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[264]:0x72565)

        at <wasm_bindgen_test::__rt::TestFuture<F> as core::future::future::Future>::poll::{{closure}}::{{closure}}::hb726a0c793bc3995 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[11506]:0x3c93cb)

        at wasm_bindgen::convert::closures::invoke0_mut::hd679e8cfa73e2075 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12410]:0x3daddb)

        at __wbg_adapter_31 (http://127.0.0.1:45623/wasm-bindgen-test:272:10)

        at cb0 (http://127.0.0.1:45623/wasm-bindgen-test:438:28)

---- ops::ops_impl::mask128::mask128x4::bitor_assign output ----

JS exception that was thrown:

    RuntimeError: unreachable

        at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x363614)

        at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

        at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

        at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

        at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

        at ops::ops_impl::mask128::mask128x4::bitor_assign::hb25b897258725486 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[266]:0x72cb1)

        at <wasm_bindgen_test::__rt::TestFuture<F> as core::future::future::Future>::poll::{{closure}}::{{closure}}::hc0896b93aa597c15 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[11596]:0x3cb36f)

        at wasm_bindgen::convert::closures::invoke0_mut::hd679e8cfa73e2075 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12410]:0x3daddb)

        at __wbg_adapter_31 (http://127.0.0.1:45623/wasm-bindgen-test:272:10)

        at cb0 (http://127.0.0.1:45623/wasm-bindgen-test:438:28)

---- ops::ops_impl::mask128::mask128x4::bitxor output ----

JS exception that was thrown:

    RuntimeError: unreachable

        at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x363614)

        at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

        at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

        at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

        at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

        at ops::ops_impl::mask128::mask128x4::bitxor::h499b762503c708a2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[263]:0x721bf)

        at <wasm_bindgen_test::__rt::TestFuture<F> as core::future::future::Future>::poll::{{closure}}::{{closure}}::hb07e3dcef1efc51c (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[11461]:0x3c83fa)

        at wasm_bindgen::convert::closures::invoke0_mut::hd679e8cfa73e2075 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12410]:0x3daddb)

        at __wbg_adapter_31 (http://127.0.0.1:45623/wasm-bindgen-test:272:10)

        at cb0 (http://127.0.0.1:45623/wasm-bindgen-test:438:28)

---- ops::ops_impl::mask128::mask128x4::bitxor_assign output ----

JS exception that was thrown:

    RuntimeError: unreachable

        at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x363614)

        at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

        at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

        at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

        at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

        at ops::ops_impl::mask128::mask128x4::bitxor_assign::h50b0501b3d030033 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[267]:0x73057)

        at <wasm_bindgen_test::__rt::TestFuture<F> as core::future::future::Future>::poll::{{closure}}::{{closure}}::hbb6aa0f070eb7bd4 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[11551]:0x3ca39d)

        at wasm_bindgen::convert::closures::invoke0_mut::hd679e8cfa73e2075 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12410]:0x3daddb)

        at __wbg_adapter_31 (http://127.0.0.1:45623/wasm-bindgen-test:272:10)

        at cb0 (http://127.0.0.1:45623/wasm-bindgen-test:438:28)

failures:

ops::ops_impl::mask128::mask128x4::bitand

ops::ops_impl::mask128::mask128x4::bitand_assign

ops::ops_impl::mask128::mask128x4::bitor

ops::ops_impl::mask128::mask128x4::bitor_assign

ops::ops_impl::mask128::mask128x4::bitxor

ops::ops_impl::mask128::mask128x4::bitxor_assign

test result: FAILED. 2212 passed; 6 failed; 0 ignored

console.log div contained:

panicked at 'assertion failed: `(left == right)`

  left: `[false (0), false (0), false (0), true (ffffffffffffffffffffffffffffffff)]`,

 right: `[false (0), false (0), true (ffffffffffffffff), true (ffffffffffffffffffffffffffffffff)]`', crates/core_simd/tests/ops_impl/mask128.rs:4:1



Stack:



Error

    at http://127.0.0.1:45623/wasm-bindgen-test:578:19

    at http://127.0.0.1:45623/wasm-bindgen-test:154:22

    at console_error_panic_hook::hook::h8a744eaa07f313f0 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[3580]:0x231cd6)

    at core::ops::function::Fn::call::h8d9f8d3764bff0d3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[14961]:0x3e4466)

    at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x3635f3)

    at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

    at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

    at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

    at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

    at ops::ops_impl::mask128::mask128x4::bitand::h71eb62a9f2d1b01d (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[265]:0x7290b)





panicked at 'assertion failed: `(left == right)`

  left: `[false (0), false (0), false (0), true (ffffffffffffffffffffffffffffffff)]`,

 right: `[false (0), false (0), true (ffffffffffffffff), true (ffffffffffffffffffffffffffffffff)]`', crates/core_simd/tests/ops_impl/mask128.rs:4:1



Stack:



Error

    at http://127.0.0.1:45623/wasm-bindgen-test:578:19

    at http://127.0.0.1:45623/wasm-bindgen-test:154:22

    at console_error_panic_hook::hook::h8a744eaa07f313f0 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[3580]:0x231cd6)

    at core::ops::function::Fn::call::h8d9f8d3764bff0d3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[14961]:0x3e4466)

    at std::panicking::rust_panic_with_hook::h7ba07724d623fbd6 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7289]:0x3635f3)

    at std::panicking::begin_panic_handler::{{closure}}::hf841a66ae6cb12c2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[7582]:0x3722d2)

    at std::sys_common::backtrace::__rust_end_short_backtrace::h1aceb706833fcda2 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12320]:0x3d9f13)

    at rust_begin_unwind (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12201]:0x3d8374)

    at core::panicking::panic_fmt::h125c8438143be5c3 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[12322]:0x3d9f77)

    at ops::ops_impl::mask128::mask128x4::bitand_assign::hc476ffd786a33543 (http://127.0.0.1:45623/wasm-bindgen-test_bg.wasm:wasm-function[268]:0x733fd)

EDIT: This problem is resolved by #44, as shown by #48.

KodrAus

Nice! 🎉

I didn't realise we already had intrinsics for rounding. Were those just added or is there some automagic handling of the simd_{op} name that lines up with the right LLVM intrinsic? (I already forget how that works...)

workingjubilee · 2020-12-04T06:11:16Z

We do not have the full set of trunc or round platform intrinsics (and so lose that functionality here), but they can be added to rustc. I wanted to make sure that this would fix that before I moved on to prioritizing that.

workingjubilee · 2020-12-04T21:15:25Z

To actually answer the question: it is indeed the case that the compiler essentially handles platform intrinsics in LLVM codegen by performing an automagic translation. This is likely why it works for riscv64gc... I suspect there is something about how the intrinsics were specified in-lib that was preempting LLVM's codegen logic.

programmerjake · 2020-12-04T21:47:45Z

To actually answer the question: it is indeed the case that the compiler essentially handles platform intrinsics in LLVM codegen by performing an automagic translation. This is likely why it works for riscv64gc... I suspect there is something about how the intrinsics were specified in-lib that was preempting LLVM's codegen logic.

Yup, we were using extern "C" which told rustc that we wanted the C ABI. The C ABI is implemented by a combination of transformations in rustc and LLVM, what was happening is we wanted the function declarations to get to LLVM unmodified, which wasn't happening since rustc was doing the transformations that are its part of implementing the C ABI. Basically we were lying to rustc about the ABI -- no wonder it broke.

bjorn3 · 2020-12-04T21:56:23Z

There is extern "unadjusted" for this usecase.

calebzulawski · 2020-12-05T01:34:47Z

Should this get merged in we should update #38 with the removed functions.

workingjubilee · 2020-12-08T23:36:56Z

@bjorn3 Wouldn't that still cause issues on cranelift's end?

bjorn3 · 2020-12-09T06:49:12Z

Yes

KodrAus · 2020-12-23T08:17:38Z

Green LED means building and running core_simd for riscv32imac-unknown-none-elf works for reals 😁

workingjubilee added 3 commits November 30, 2020 19:26

Revert "Disable riscv64gc"

7538ff8

This reverts commit 3ad356d.

Remove round, trunc tests

e9cc306

There are no platform intrinsics in the rustc for these functions yet, so this removes them as a distinct commit for later reversion.

Use simd_{floor,ceil} intrinsics for round.rs

3d9bbf9

workingjubilee force-pushed the less-llvm branch from 3d9bbf9 to e9cc306 Compare December 4, 2020 02:32

workingjubilee marked this pull request as ready for review December 4, 2020 02:39

workingjubilee requested a review from calebzulawski December 4, 2020 02:45

workingjubilee mentioned this pull request Dec 4, 2020

[TEST ONLY] I am bors #48

Closed

KodrAus approved these changes Dec 4, 2020

View reviewed changes

calebzulawski approved these changes Dec 5, 2020

View reviewed changes

workingjubilee mentioned this pull request Dec 8, 2020

Additional rounding functions #38

Closed

5 tasks

workingjubilee merged commit a69c441 into master Dec 8, 2020

workingjubilee mentioned this pull request Dec 10, 2020

Get Cranelifted #40

Open

KodrAus deleted the less-llvm branch January 19, 2021 23:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use platform intrinsics, not LLVM, for floor & ceil #47

Use platform intrinsics, not LLVM, for floor & ceil #47

workingjubilee commented Dec 1, 2020 •

edited

Loading

workingjubilee commented Dec 1, 2020

workingjubilee commented Dec 4, 2020

workingjubilee commented Dec 4, 2020 •

edited

Loading

KodrAus left a comment

workingjubilee commented Dec 4, 2020

workingjubilee commented Dec 4, 2020

programmerjake commented Dec 4, 2020

bjorn3 commented Dec 4, 2020 •

edited

Loading

calebzulawski commented Dec 5, 2020

workingjubilee commented Dec 8, 2020

bjorn3 commented Dec 9, 2020

KodrAus commented Dec 23, 2020

Use platform intrinsics, not LLVM, for floor & ceil #47

Use platform intrinsics, not LLVM, for floor & ceil #47

Conversation

workingjubilee commented Dec 1, 2020 • edited Loading

workingjubilee commented Dec 1, 2020

workingjubilee commented Dec 4, 2020

workingjubilee commented Dec 4, 2020 • edited Loading

KodrAus left a comment

Choose a reason for hiding this comment

workingjubilee commented Dec 4, 2020

workingjubilee commented Dec 4, 2020

programmerjake commented Dec 4, 2020

bjorn3 commented Dec 4, 2020 • edited Loading

calebzulawski commented Dec 5, 2020

workingjubilee commented Dec 8, 2020

bjorn3 commented Dec 9, 2020

KodrAus commented Dec 23, 2020

workingjubilee commented Dec 1, 2020 •

edited

Loading

workingjubilee commented Dec 4, 2020 •

edited

Loading

bjorn3 commented Dec 4, 2020 •

edited

Loading