Skip to content

Commit

Permalink
fix: Typo
Browse files Browse the repository at this point in the history
Co-authored-by: Weihang Lo <[email protected]>
  • Loading branch information
epage and weihanglo authored Nov 13, 2023
1 parent 153b413 commit ec500c2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion text/3516-public-private-dependencies.md
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ version should resolve to (clap 3.4 vs clap 4.0), then it is an error.

Compared to the resolver doing this implicitly
- It is unclear if this would be any more difficult to implement in the resolver
- Changing a dependency from `public = false` to `public = true` is backwards compatible because it has no affect on existing callers.
- Changing a dependency from `public = false` to `public = true` is backwards compatible because it has no effect on existing callers.
- It is unclear how this would handle multiple versions of a package that are public

The downside is it feels like the declaration is backwards.
Expand Down

0 comments on commit ec500c2

Please sign in to comment.