-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async closures #3668
Merged
traviscross
merged 25 commits into
rust-lang:master
from
compiler-errors:async-closure-redux
Aug 3, 2024
Merged
Async closures #3668
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
80249c9
Add async closure redux RFC
compiler-errors 6000a0c
update numbers
compiler-errors a514d3b
Clarify section about associated types being reserved
traviscross d2446cb
No perma
compiler-errors 29582aa
More clarifications
compiler-errors 3938f65
Add missing generics
compiler-errors 86fc14a
Motivate why non-async closures should implement AsyncFn
compiler-errors 90ea425
Clarify the ?for<'a> weirdness
compiler-errors febff99
One more caveat about AsyncFn* and built-in impls
compiler-errors 23b9af8
Grammar nit wrt ? and async
compiler-errors 26ded68
Oops, missing words
compiler-errors b2a8e07
Update text/3668-async-closure.md
compiler-errors 3298481
Fix hackmd-ism
compiler-errors 88faa5b
Recommend for users to write
compiler-errors 59e0eb2
More writing
compiler-errors 694d0df
Why no AsyncFnOnce::Output
compiler-errors 2e35b78
Elaborate slightly the section on FnOnce
compiler-errors 662654b
Slightly elaborate drawback with non-nameable RTN
compiler-errors ee9b0cd
Update text/3668-async-closure.md
compiler-errors 3681ffd
more nits
compiler-errors f8c6e9f
whoops
compiler-errors 186ce20
Rename file for RFC 3668 to plural
traviscross cb803f0
Add section about how `AsyncFn` commits us also
traviscross 86ad484
Reserve some space for async Fn bounds not converging on consensus
compiler-errors 576b9f4
Update text/3668-async-closures.md
compiler-errors File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a future where
async Fn()
still has no meaning, butasync SomeOtherTrait
does, in a way that is not analogous toAsyncFn()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then those meanings can coexist since by definition they don't overlap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also feel like at this point it's not productive to debate against a "what if" that's quantified over a space of possibilities that's not really enumerable. I'm happy to say that any
async Trait
design that conflicts with at least the broad, user-facing observables of the definition ofasync Fn
is not worth considering.