Skip to content

fix: Allow leading | in more pattern positions #13096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix: Allow leading | in more pattern positions #13096

merged 1 commit into from
Aug 23, 2022

Conversation

jonas-schievink
Copy link
Contributor

fixes #12894, fixes #13094

Oddly, the leading | token does not end up inside the OR_PAT node, since pattern_top_r consumes it first. This is a preexisting issue in match arms though, so I didn't fix it here.

@jonas-schievink
Copy link
Contributor Author

@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2022

📌 Commit 8969655 has been approved by jonas-schievink

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 23, 2022

⌛ Testing commit 8969655 with merge e73b7a9...

@bors
Copy link
Contributor

bors commented Aug 23, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing e73b7a9 to master...

@bors bors merged commit e73b7a9 into rust-lang:master Aug 23, 2022
@jonas-schievink jonas-schievink deleted the parse-more-or-pats branch August 23, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-analyzer can't parse leading | in patterns Allow patterns with leading | in more places
2 participants