Migrate merge_imports
Assist to Use SyntaxFactory
#18484
Draft
+97
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #15710 and #18285.
Changes Made
SyntaxEditor
#18285 for migration.edits_mut
vector fromcrates/ide-assists/src/handlers/merge_imports.rs
SyntaxFactory
methodwhitespace
whitespace
as it mirrorsmake::tokens::whitespace
buttokens_whitespace
might be a more fitting name.edit_in_place::Removable
trait withedit_in_place::EditorRemovable
(Relevant conversation here)SyntaxEditor
instance in theremove
method to use instead ofted
.ast::Use
andast::UseTree
SyntaxEditor::delete
instead ofted::remove
andted::remove_all_iter
. SinceSyntaxEditor::remove
doesn’t exist, I assumed delete would perform the same function—though this might be causing issues.