Better handle parallelism in cache priming #19721
Open
+171
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make best use of available cores, and don't waste time waiting for other tasks. See the comments in the code for explanation.
And make it parallel by default (and remove the `--parallel` flag) to mirror the IDE cache priming.
rustbot
added
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make best use of all available CPU cores.
Closes #19711.
Also change the flags of the
prime-cachesCLI command, and make it parallel by default.This saves 0.305ms in the parallel
prime-cacheson omicron, although the benchmarks were very noisy.I ran into a Salsa panic while running parallel prime caches on buck2... Need to debug that, but it doesn't reproduce now.