fix: Fix inference of AsyncFnX return type
#19872
Merged
+81
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
approved these changes
May 27, 2025
Comment on lines
+437
to
+439
| let TyKind::Tuple(_, input_tys) = arg_param_ty.kind(Interner) else { | ||
| return None; | ||
| }; |
There was a problem hiding this comment.
dumb question: under what circumstances would we not get a TyKind::Tuple here?
There was a problem hiding this comment.
I don't know but I can guess it can happen if users are messing with the raw fn_traits unstable feature. This was in extract_sig_from_projection() so I duplicated it.
There was a problem hiding this comment.
I could panic here, but generally in r-a we avoid panicking except in extreme cases (defensive coding and not offensive coding), because you don't know where the bugs lurk, and IDE crashing is way worse than some incorrect inference.
Veykril
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19845.