fix: Skip pattern analysis on type mismatches #19875
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19844
Playing with tracings on rustc, I found that it never enters
rustc_pattern_analysis
if there exists any typecheck error inside the given body:tcx.thir_body()?
tcx.thir_body()
implementationWe've been doing simillar "skip on type-error" things on the following lines:
rust-analyzer/crates/hir-ty/src/diagnostics/expr.rs
Lines 210 to 225 in 7230ded
rust-analyzer/crates/hir-ty/src/diagnostics/expr.rs
Lines 160 to 163 in 7230ded
But unfortunately not on the line in this PR