Add ide-assist: generate_impl_trait for generate_impl #19938
+304
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
A4-Tacks
changed the title
A4-Tacks
changed the title
|
r? @Veykril |
| } | ||
|
|
||
| impl Foo<${1:_}> for ${2:_} { | ||
| $0fn foo(&self) -> _ { |
There was a problem hiding this comment.
Do we need a tabstop here?
There was a problem hiding this comment.
Used to fill in generic parameters?
There was a problem hiding this comment.
I mean, before the fn keyword
|
Besides tabstop, other things look good |
ShoyuVanilla
approved these changes
Jun 28, 2025
| } | ||
|
|
||
| if let Some(item) = impl_.assoc_item_list().and_then(|it| it.assoc_items().next()) { | ||
| edit.add_tabstop_before(cap, item); |
There was a problem hiding this comment.
I was confused because I'm in my phone outside 😅
I mean, do we need this tabstop before the first assoc item of a trait?
There was a problem hiding this comment.
When implementing traits, positioning the cursor nearby is more convenient for editing todo!()
There was a problem hiding this comment.
Then the tabstop should probably be on the todo!()
There was a problem hiding this comment.
Then the tabstop should probably be on the
todo!()
ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds this trait impl for a type.
->