Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Option::map_or(true, …) in unnecessary_map_or lint #13653

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Handle Option::map_or(true, …) in unnecessary_map_or lint #13653

wants to merge 3 commits into from

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Nov 4, 2024 •
edited
Loading

changelog: [unnecessary_map_or]: handle Option::map_or(true, …)

@rustbot
Copy link
Collaborator

rustbot commented Nov 4, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 4, 2024
@samueltardieu
Copy link
Contributor Author

Even though it is not to be merged yet (mostly because #11796 isn't merged),

r? @Centri3

@rustbot rustbot assigned Centri3 and unassigned Jarcho Nov 4, 2024
@bors
Copy link
Contributor

bors commented Nov 7, 2024

☔ The latest upstream changes (presumably #13639) made this pull request unmergeable. Please resolve the merge conflicts.

@samueltardieu samueltardieu marked this pull request as ready for review November 7, 2024 19:33
@samueltardieu samueltardieu mentioned this pull request Nov 7, 2024
Merged
@samueltardieu
Copy link
Contributor Author

In addition to the fixed instances in Clippy itself, lintcheck found one instance in Cargo. Since it requires at least a 1.82 Rust version, we will see a progressive effect as the MSRV of the targets advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centri3 Centri3 Awaiting requested review from Centri3

Assignees

@Centri3 Centri3

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samueltardieu @rustbot @bors @Jarcho @Centri3