Move more def paths into clippy_utils::paths
#13903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
y21
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Good catch, lgtm.
CI is failing because the invalid_paths internal lint currently doesn't understand char inherent impls. The proper fix might be as simple as adding SimplifiedType::Char here, or if you just want to #[expect(clippy::invalid_paths)] the failing lint here since it isn't really related to this change that's fine too, r=me in any case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that there were paths declared in
clippy_utils::pathsin #13829 so moving a few remaining hardcoded ones in one place.changelog: Move more def paths into
clippy_utils::pathsr? @y21