-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new lint: deref coercions
#14059
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
deref coercions
lint #7104deref coercions
deref coercions
deref coercions
Out of curiosity, do you know of any project or style guide which forbids deref coercions in its codebase? |
I don't know. I love using deref coercions, but I hope this one might be useful to some people... Because, over the years, I've seen some people who dislike it. |
I am asking because to me it looks like a lint which enforces a non-existing practice, and for which there is no demand. If I was the one deciding whether to accept it or not, I would seriously weight this against the additional maintenance burden, and probably reject it. |
Hi, I added a new lint
deref coercions
to resolve #7104.This is my first time contributing to clippy, so please leave me some feedbacks!
changelog: [deref_coercions]: new lint