Check for proc macros from within explicit_deref_methods and do not lint on proc macro expansions
#15628
+52
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Justus Flügel <[email protected]>
JustusFluegel
force-pushed
the
master
branch
from
d2efe80 to
3840897
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
I rebased ontop of latest |
JustusFluegel
force-pushed
the
master
branch
from
3840897 to
fdcc34d
Compare
|
Sorry it took a while but finally got around to adding the comment. If anyone has any further review comments, they are very welcome :) |
Signed-off-by: Justus Flügel <[email protected]>
JustusFluegel
force-pushed
the
master
branch
from
fdcc34d to
3e65620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
is_from_proc_macro(...,...)check to theexplicit_deref_methodslint.Note that this is my first contribution to clippy and i am not 100% sure that this is how such bugs are intended to be fixed, so please be kind with any feedback, I appreciate that a lot! Thanks!
changelog: [
explicit_deref_methods]: no longer triggers from within proc macro expansionsfixes #15168