feat(cast_ptr_alignment): also lint to-types with unknown alignment #15879
+99
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lintcheck changes for 3d18841
This comment will be updated if you push new changes |
ada4a
force-pushed
the
cast_alignment
branch
2 times, most recently
from
3cc75c8 to
0f51832
Compare
|
Considering this is a draft rn, what is still WIP? |
The implementation should be complete, but I wasn't sure whether this is a desirable change in the first place, which is why I added |
Centri3
added
the
I-nominated
|
Instead of an FCP, I'm gonna nominate this for the next meeting. Feel free to make a Zulip thread instead tho if you want! |
Centri3
removed
the
I-nominated
|
Oh cool, checked Zulip and you already did it! |
|
Yes, sorry, forgot to post the link here 😅 There wasn't too much activity there yet though, so it could be discussed a bit more thoroughly in the meeting:) |
Centri3
added
the
I-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3440
changelog: [
cast_ptr_alignment]: also lint to-types with unknown alignment